fix(clean-code): nettoyage de fichiers obsolètes, traitement des aler…

…tes SonarCloud

_docs/dev/30.tests.md

@@ -51,49 +51,6 @@ DOMIFA_FILTER_SEC_TEST=Agenda ENV_FILE=tests-local npx jest -- app-controllers.s
 
 Note: il est aussi possible de filter par tags: <https://codecept.io/advanced/#tags>
 
-### Tests e2e backend
-
-**NOTE**: actuellement non-exécuté par la CI et non maintenu
-
-**TODO**: à réparer
-
-Restaurer les bases de test:
-
-```bash
-_scripts/db/restore-database-docker.sh --db=test
-```
-
-Démarrer le backend de test (les éventuelles migrations vont être appliquées au démarrage du serveur):
-
-```bash
-# /app/packages/backend
-# démarrer le backend (branché sur les bases de test)
-yarn start:tests-local
-```
-
-Démarrer le frontend:
-
-```bash
-# démarrer le frontend
-yarn start
-```
-
-Pour n'exécuter que certains tests:
-
-```bash
-# filter by test name
-npx codeceptjs run --features --debug ../../features/users/register.feature
-npx codeceptjs run --features --debug ../../features/stats/stats.feature
-# grep filter (run all tests with name containing "register")
-npx codeceptjs run --features --debug --grep register
-```
-
-Pour exécuter les tests via une interface graphique:
-
-```bash
-yarn test:open-ui
-```
-
 ## Mettre à jour les données de test
 
 Installer la dernière version des dumps:

packages/backend/Dockerfile

@@ -1,7 +1,7 @@
 # ---------------------------------------------------------
 # 1) BUILDER IMAGE
 # ---------------------------------------------------------
-FROM node:16.19-bullseye as builder
+FROM node:16.19-bullseye AS builder
 
 ENV TZ Europe/Paris
 

packages/backend/src/_portail-admin/admin-structures/controllers/admin-structures.controller.ts

@@ -141,9 +141,7 @@ export class AdminStructuresController {
   @Get("stats")
   @AllowUserProfiles("super-admin-domifa")
   public async stats(): Promise<AdminStructureStatsData> {
-    const stats =
-      await this.adminStructuresService.getStatsDomifaAdminDashboard();
-    return stats;
+    return await this.adminStructuresService.getStatsDomifaAdminDashboard();
   }
 
   @Get("")

packages/backend/src/auth/guards/CanGetUserStructure.guard.ts

@@ -26,7 +26,6 @@ export class CanGetUserStructureGuard implements CanActivate {
       );
       throw new HttpException("Invalid structureId", HttpStatus.FORBIDDEN);
     }
-    // TODO: remplacer par une jointure
     const chosenUserStructure = await userStructureRepository.findOne(
       {
         id: userId,

packages/backend/src/database/entities/message-sms/MessageSmsTable.typeorm.ts

@@ -15,8 +15,6 @@ export class MessageSmsTable
   extends AppTypeormTable<MessageSmsTable>
   implements MessageSms
 {
-  // TODO: associer un usagerUUID
-  // Infos usager
   @Column({ type: "integer" })
   @Index()
   public usagerRef: number;

packages/backend/src/usagers/services/custom-docs/tests/buildCustomDoc.service.spec.ts

@@ -1,7 +1,7 @@
 import { buildCustomDoc } from "..";
 import { AppTestHelper } from "../../../../util/test";
-import { STRUCTURE_MOCK } from "../../../../_common/mocks";
 import {
+  STRUCTURE_MOCK,
   USAGER_REFUS_MOCK,
   USAGER_VALIDE_MOCK,
 } from "../../../../_common/mocks";

packages/backend/src/users/users.controller.spec.ts

@@ -3,9 +3,8 @@ import { HttpModule } from "@nestjs/axios";
 import { MailsModule } from "../mails/mails.module";
 import { StructuresModule } from "../structures/structure.module";
 import { UsagersModule } from "../usagers/usagers.module";
-import { AppTestContext, AppTestHelper } from "../util/test";
+import { AppTestContext, AppTestHelper, AppTestHttpClient } from "../util/test";
 import { UsersController } from "./users.controller";
-import { AppTestHttpClient } from "../util/test";
 import { userMock } from "../_common/mocks";
 import { TESTS_USERS_STRUCTURE } from "../_tests";
 import { usersDeletor } from "./services/users-deletor.service";

packages/frontend/Dockerfile

@@ -1,4 +1,4 @@
-FROM node:16.19.0 as builder
+FROM node:16.19.0 AS builder
 USER node
 
 # these variables are needed at build time because we produce a *static* app

packages/frontend/src/app/app-routing.module.ts

@@ -55,15 +55,15 @@ export const routes: Routes = [
     path: "stats",
   },
   {
-    canActivate: [AuthGuard],
+    canLoad: [AuthGuard],
     loadChildren: () =>
       import("./modules/manage-usagers/manage-usagers.module").then(
         (m) => m.ManageUsagersModule
       ),
     path: "manage",
   },
   {
-    canActivate: [AuthGuard, FacteurGuard],
+    canLoad: [AuthGuard, FacteurGuard],
     loadChildren: () =>
       import("./modules/import-usagers/import-usagers.module").then(
         (m) => m.ImportUsagersModule
@@ -76,15 +76,15 @@ export const routes: Routes = [
     path: "users",
   },
   {
-    canActivate: [AuthGuard, FacteurGuard],
+    canLoad: [AuthGuard, FacteurGuard],
     loadChildren: () =>
       import("./modules/usager-dossier/usager-dossier.module").then(
         (m) => m.UsagerDossierModule
       ),
     path: "usager",
   },
   {
-    canActivate: [AuthGuard],
+    canLoad: [AuthGuard],
     loadChildren: () =>
       import("./modules/usager-profil/usager-profil.module").then(
         (m) => m.UsagerProfilModule

packages/frontend/src/app/modules/shared/services/auth.service.ts

@@ -30,7 +30,7 @@ export class AuthService {
   ) {
     this.currentUserSubject = new BehaviorSubject<UserStructure | null>(
       localStorage.getItem("currentUser") !== null
-        ? JSON.parse(localStorage.getItem("currentUser") as string)
+        ? JSON.parse(localStorage.getItem("currentUser"))
         : null
     );
   }

packages/portail-admins/Dockerfile

@@ -1,4 +1,4 @@
-FROM node:16.19.0 as builder
+FROM node:16.19.0 AS builder
 USER node
 
 # these variables are needed at build time because we produce a *static* app

packages/portail-admins/src/_common/structure/StructurePublic.type.ts

@@ -3,7 +3,7 @@ import { StructureType, StructureAddresseCourrier } from ".";
 import { AppEntity } from "../_core";
 
 export type StructurePublic = AppEntity & {
-  id: number; // TODO: à voir si c'est utile
+  id: number;
   adresse: string;
   complementAdresse: string;
   nom: string;

packages/portail-admins/src/app/modules/general/components/_static/politique/politique.component.ts

@@ -4,7 +4,6 @@ import { Title } from "@angular/platform-browser";
 @Component({
   selector: "app-politique",
   templateUrl: "./politique.component.html",
-  styleUrls: ["./politique.component.css"],
 })
 export class PolitiqueComponent implements OnInit {
   public constructor(private titleService: Title) {}

packages/portail-admins/src/assets/css/main.css

@@ -177,11 +177,3 @@ html {
   background-color: var(--bs-primary);
   width: 100%;
 }
-
-.head-page .title,
-.head-page h1 {
-  font-style: normal;
-  font-weight: bold;
-  font-size: 1.7rem;
-  color: #ffffff;
-}

packages/portail-usagers/Dockerfile

@@ -1,4 +1,4 @@
-FROM node:16.19.0 as builder
+FROM node:16.19.0 AS builder
 USER node
 
 # these variables are needed at build time because we produce a *static* app

packages/portail-usagers/src/app/modules/shared/pipes/formatInternationalPhoneNumber.pipe.ts

@@ -16,11 +16,7 @@ export class FormatInternationalPhoneNumberPipe implements PipeTransform {
         telephone.numero,
         telephone.countryCode.toUpperCase(),
       );
-      const internationalPhone = this.phoneUtil.format(
-        numero,
-        lpn.PhoneNumberFormat.INTERNATIONAL,
-      );
-      return internationalPhone;
+      return this.phoneUtil.format(numero, lpn.PhoneNumberFormat.INTERNATIONAL);
     } catch (error) {
       console.warn(error);
       return "Non renseigné";

packages/portail-usagers/src/app/modules/usager-account/components/section-options/section-options.component.ts

@@ -8,7 +8,6 @@ import {
 @Component({
   selector: "app-section-options",
   templateUrl: "./section-options.component.html",
-  styleUrls: ["./section-options.component.css"],
 })
 export class SectionOptionsComponent implements OnInit {
   @Input() public usager!: PortailUsagerPublic;