Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(admin): refactor search & design #3587

Merged
merged 2 commits into from
Dec 3, 2024
Merged

feat(admin): refactor search & design #3587

merged 2 commits into from
Dec 3, 2024

Conversation

pYassine
Copy link
Contributor

@pYassine pYassine commented Dec 2, 2024

No description provided.

Copy link

socket-security bot commented Dec 3, 2024

Report too large to display inline

View full report↗︎

@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 84.61538% with 6 lines in your changes missing coverage. Please review.

Project coverage is 66.69%. Comparing base (5a3040f) to head (a4b72cb).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...kend/src/usagers/controllers/usagers.controller.ts 25.00% 2 Missing and 1 partial ⚠️
...modules/mails/services/_core/smtpSender.service.ts 0.00% 2 Missing ⚠️
...ntact-support/contactSupportEmailSender.service.ts 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3587      +/-   ##
==========================================
- Coverage   66.87%   66.69%   -0.19%     
==========================================
  Files         918      909       -9     
  Lines       15015    14852     -163     
  Branches     2112     2064      -48     
==========================================
- Hits        10042     9905     -137     
+ Misses       4666     4641      -25     
+ Partials      307      306       -1     
Files with missing lines Coverage Δ
...src/modules/contact-support/contact-support.dto.ts 46.66% <ø> (ø)
...services/_core/DOMIFA_DEFAULT_MAIL_CONFIG.const.ts 100.00% <ø> (ø)
...portail-admin/services/admin-structures.service.ts 100.00% <ø> (ø)
...kages/frontend/src/_common/model/_general/index.ts 100.00% <ø> (ø)
packages/frontend/src/_common/model/index.ts 100.00% <ø> (ø)
...ge-usagers-page/manage-usagers-page.component.html 100.00% <ø> (ø)
...nage-usagers-page/manage-usagers-page.component.ts 23.90% <ø> (ø)
...ge-usagers-table/manage-usagers-table.component.ts 42.64% <ø> (ø)
.../components/usager-filter/UsagersFilterCriteria.ts 100.00% <100.00%> (ø)
...ts/usager-filter/services/usagersSorter.service.ts 96.77% <100.00%> (-0.20%) ⬇️
... and 17 more

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a3040f...a4b72cb. Read the comment docs.

@pYassine pYassine marked this pull request as ready for review December 3, 2024 01:20
Copy link

sonarqubecloud bot commented Dec 3, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Copy link

github-actions bot commented Dec 3, 2024

🎉 Deployment for commit a4b72cb :

Ingresses
Docker images
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/backend:sha-a4b72cb3f411a217b94cf1ce4c57aa49dfc5b335
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/frontend:sha-a4b72cb3f411a217b94cf1ce4c57aa49dfc5b335
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-admins:sha-a4b72cb3f411a217b94cf1ce4c57aa49dfc5b335
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-usagers:sha-a4b72cb3f411a217b94cf1ce4c57aa49dfc5b335
Debug

@pYassine pYassine merged commit faeaa64 into master Dec 3, 2024
13 of 14 checks passed
@pYassine pYassine deleted the feat-admin-refactor branch December 3, 2024 09:24
@SocialGroovyBot
Copy link
Member

🎉 This PR is included in version 2.187.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants