Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): fix head of columns #3592

Merged
merged 2 commits into from
Dec 12, 2024
Merged

fix(frontend): fix head of columns #3592

merged 2 commits into from
Dec 12, 2024

Conversation

pYassine
Copy link
Contributor

No description provided.

@pYassine pYassine marked this pull request as ready for review December 12, 2024 13:45
Copy link

🎉 Deployment for commit 778152e :

Ingresses
Docker images
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/backend:sha-778152ed22d58ebcd3070ad515898587c2b591fd
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/frontend:sha-778152ed22d58ebcd3070ad515898587c2b591fd
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-admins:sha-778152ed22d58ebcd3070ad515898587c2b591fd
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-usagers:sha-778152ed22d58ebcd3070ad515898587c2b591fd
Debug

@pYassine pYassine merged commit 5aac576 into master Dec 12, 2024
12 of 13 checks passed
@pYassine pYassine deleted the fix-head-columns branch December 12, 2024 14:39
@SocialGroovyBot
Copy link
Member

🎉 This PR is included in version 2.187.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 27.58621% with 21 lines in your changes missing coverage. Please review.

Project coverage is 66.64%. Comparing base (ee1ce5b) to head (008d9b4).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...ge-usagers-table/manage-usagers-table.component.ts 34.78% 13 Missing and 2 partials ⚠️
...kend/src/usagers/controllers/usagers.controller.ts 0.00% 6 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3592      +/-   ##
==========================================
- Coverage   66.69%   66.64%   -0.05%     
==========================================
  Files         909      909              
  Lines       14852    14870      +18     
  Branches     2063     2064       +1     
==========================================
+ Hits         9905     9910       +5     
+ Misses       4776     4653     -123     
- Partials      171      307     +136     
Files with missing lines Coverage Δ
...ge-usagers-page/manage-usagers-page.component.html 100.00% <ø> (ø)
...nts/manage-usagers-table/manage-usagers-table.html 100.00% <ø> (ø)
...kend/src/usagers/controllers/usagers.controller.ts 52.34% <0.00%> (+0.69%) ⬆️
...ge-usagers-table/manage-usagers-table.component.ts 38.63% <34.78%> (-4.02%) ⬇️

... and 57 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee1ce5b...008d9b4. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants