Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): add cerfa with new dates #3594

Merged
merged 5 commits into from
Dec 17, 2024
Merged

feat(frontend): add cerfa with new dates #3594

merged 5 commits into from
Dec 17, 2024

Conversation

pYassine
Copy link
Contributor

No description provided.

@pYassine pYassine marked this pull request as ready for review December 13, 2024 16:32
Comment on lines +68 to +70
domifaPlace = await openDataPlaceRepository.save(
new OpenDataPlaceTable(placeData)
);

Check warning

Code scanning / CodeQL

Useless assignment to local variable Warning

The value assigned to domifaPlace here is unused.
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

if (a === null || a === undefined) return 1;
if (b === null || b === undefined) return -1;
}

// Détecter si c'est une date valide
// Conversion immédiate en string
const strA = a === null || a === undefined ? "" : String(a);

Check notice

Code scanning / CodeQL

Unneeded defensive code Note

This guard always evaluates to false.
if (a === null || a === undefined) return 1;
if (b === null || b === undefined) return -1;
}

// Détecter si c'est une date valide
// Conversion immédiate en string
const strA = a === null || a === undefined ? "" : String(a);

Check notice

Code scanning / CodeQL

Unneeded defensive code Note

This guard always evaluates to false.
// Détecter si c'est une date valide
// Conversion immédiate en string
const strA = a === null || a === undefined ? "" : String(a);
const strB = b === null || b === undefined ? "" : String(b);

Check notice

Code scanning / CodeQL

Unneeded defensive code Note

This guard always evaluates to false.
packages/common/src/search/sorter/dataSorter.service.ts Dismissed Show dismissed Hide dismissed
@pYassine pYassine merged commit 2aa6fa0 into master Dec 17, 2024
11 of 14 checks passed
@pYassine pYassine deleted the feat-cerfa-dates branch December 17, 2024 14:17
@SocialGroovyBot
Copy link
Member

🎉 This PR is included in version 2.188.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants