Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix referrerName pipe & search of phones #3642

Merged
merged 3 commits into from
Jan 28, 2025
Merged

Fix referrerName pipe & search of phones #3642

merged 3 commits into from
Jan 28, 2025

Conversation

pYassine
Copy link
Contributor

No description provided.

@pYassine pYassine marked this pull request as ready for review January 28, 2025 01:05
@pYassine pYassine merged commit 23d4eb5 into master Jan 28, 2025
9 checks passed
@pYassine pYassine deleted the feat-referent branch January 28, 2025 01:10
@tokenbureau
Copy link

tokenbureau bot commented Jan 28, 2025

🎉 This PR is included in version 2.194.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@tokenbureau tokenbureau bot added the released label Jan 28, 2025
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 43.01075% with 53 lines in your changes missing coverage. Please review.

Project coverage is 66.81%. Comparing base (dc0f7e9) to head (4b59df5).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...nage-usagers-page/manage-usagers-page.component.ts 9.52% 18 Missing and 1 partial ⚠️
...ules/manage-users/services/manage-users.service.ts 47.05% 9 Missing ⚠️
...ons/1737390477603-clean-phone-numbers-migration.ts 27.27% 7 Missing and 1 partial ⚠️
.../modules/usager-shared/pipes/referrer-name.pipe.ts 14.28% 5 Missing and 1 partial ⚠️
...rs/components/user-profil/user-profil.component.ts 0.00% 4 Missing ⚠️
...-dossier/components/step-rdv/step-rdv.component.ts 0.00% 3 Missing ⚠️
...kend/src/usagers/controllers/usagers.controller.ts 50.00% 2 Missing ⚠️
...c/usagers/controllers/search-usagers.controller.ts 50.00% 1 Missing ⚠️
.../components/usager-filter/UsagersFilterCriteria.ts 80.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3642      +/-   ##
==========================================
- Coverage   66.82%   66.81%   -0.02%     
==========================================
  Files         925      926       +1     
  Lines       15260    15288      +28     
  Branches     2127     2124       -3     
==========================================
+ Hits        10198    10214      +16     
+ Misses       4886     4766     -120     
- Partials      176      308     +132     
Files with missing lines Coverage Δ
...ep2-validate-row/usagersImportValidator.service.ts 91.42% <100.00%> (ø)
...kages/backend/src/usagers/dto/search-usager.dto.ts 95.45% <100.00%> (+0.45%) ⬆️
...c/usagers/services/cerfa/tests/CERFA_MOCKS.mock.ts 100.00% <ø> (ø)
...docs/tests/CUSTOM_DOC_ATTESTATION_POSTALE.const.ts 100.00% <ø> (ø)
...ces/custom-docs/tests/CUSTOM_DOC_COURRIER_REFUS.ts 100.00% <ø> (ø)
...es/backend/src/usagers/services/usagers.service.ts 46.49% <100.00%> (+1.44%) ⬆️
...ure-usagers-renderer/renderStructureUsagersRows.ts 97.82% <ø> (ø)
...usagers-renderer/tests/FIRST_SHEET_USAGERS.mock.ts 100.00% <ø> (ø)
...backend/src/usagers/utils/validate-search-field.ts 81.81% <100.00%> (-1.52%) ⬇️
...kages/backend/src/util/phone/phoneUtils.service.ts 67.74% <100.00%> (-3.23%) ⬇️
... and 21 more

... and 58 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc0f7e9...4b59df5. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants