Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test case to check if Insert operation exists while updating a class #148

Closed

Conversation

algomaster99
Copy link
Member

Signed-off-by: Aman Sharma [email protected]

The changes add a test case to test #147.

@algomaster99
Copy link
Member Author

Hi @martinezmatias,

I have added the test case. Please check.

@martinezmatias
Copy link
Contributor

Thanks @algomaster99 ! I will take a look

@monperrus
Copy link
Contributor

@algomaster99 would you be able to propose a patch? Thanks!

@algomaster99
Copy link
Member Author

algomaster99 commented Jun 22, 2021

@monperrus The failing test case stems from the ActionClassifier unable to correctly identify UpdateOperation. More on this has been discussed in #125 .

I have kept this issue on priority as it is also a requirement for diffmin. I proposed the first draft of a patch in the comments of the same issue after discussing it with @martinezmatias and @slarse . While I wait for their reviews on my comment, I am trying to improve the approach to the solution myself.

Once #125 is resolved, this test case would pass too :)

@algomaster99 algomaster99 deleted the root-operation-bug-test branch September 23, 2021 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants