Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Lake compaction scheduler optimize in fe restart scenarios #54881

Merged
merged 2 commits into from
Jan 22, 2025
Merged

[Enhancement] Lake compaction scheduler optimize in fe restart scenarios #54881

merged 2 commits into from
Jan 22, 2025

Conversation

wxl24life
Copy link
Contributor

@wxl24life wxl24life commented Jan 9, 2025 •
edited
Loading

Why I'm doing:

What I'm doing:

Fixes #54883

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@wxl24life wxl24life requested a review from a team as a code owner January 9, 2025 08:36
@wanpengfei-git wanpengfei-git requested a review from a team January 9, 2025 08:39
@wxl24life wxl24life force-pushed the xiaolong/github-main-compaction-txn-on-restart branch 3 times, most recently from 8b274cc to 2803208 Compare January 12, 2025 14:48
@wanpengfei-git wanpengfei-git removed the request for review from a team January 12, 2025 14:49
@wxl24life wxl24life force-pushed the xiaolong/github-main-compaction-txn-on-restart branch 9 times, most recently from c16bc22 to 5698de2 Compare January 19, 2025 09:26
@wxl24life wxl24life force-pushed the xiaolong/github-main-compaction-txn-on-restart branch from 5698de2 to 51d052b Compare January 19, 2025 09:27
@wxl24life wxl24life force-pushed the xiaolong/github-main-compaction-txn-on-restart branch from a264e07 to 5c1382c Compare January 20, 2025 11:09
@wxl24life
fix comments
ed497ed 
Signed-off-by: drake_wang <[email protected]>
@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 34 / 36 (94.44%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/transaction/LakeTableTxnLogApplier.java 0 2 00.00% [102, 103]
🔵 com/starrocks/transaction/DatabaseTransactionMgr.java 7 7 100.00% []
🔵 com/starrocks/lake/compaction/CompactionScheduler.java 1 1 100.00% []
🔵 com/starrocks/lake/compaction/CompactionMgr.java 20 20 100.00% []
🔵 com/starrocks/transaction/GlobalTransactionMgr.java 6 6 100.00% []

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@HangyuanLiu HangyuanLiu merged commit e886985 into StarRocks:main Jan 22, 2025
54 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.4

@github-actions github-actions bot removed the 3.4 label Jan 22, 2025
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Jan 22, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 22, 2025 •
edited
Loading

backport branch-3.4

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 22, 2025 •
edited
Loading

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 22, 2025
@wxl24life @mergify
[Enhancement] Lake compaction scheduler optimize in fe restart scenar…
8c6cb43 
…ios (#54881)

Signed-off-by: drake_wang <[email protected]>
(cherry picked from commit e886985)
@mergify mergify bot mentioned this pull request Jan 22, 2025
Open
18 tasks
mergify bot pushed a commit that referenced this pull request Jan 22, 2025
@wxl24life @mergify
[Enhancement] Lake compaction scheduler optimize in fe restart scenar…
b5bf3ec 
…ios (#54881)

Signed-off-by: drake_wang <[email protected]>
(cherry picked from commit e886985)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/transaction/TransactionStateSnapshot.java
@mergify mergify bot mentioned this pull request Jan 22, 2025
Closed
18 tasks
@wxl24life wxl24life deleted the xiaolong/github-main-compaction-txn-on-restart branch January 22, 2025 03:21
@smartlxh
Copy link
Contributor

@mergify backport branch-3.2

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 22, 2025 •
edited
Loading

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 22, 2025
@wxl24life @mergify
[Enhancement] Lake compaction scheduler optimize in fe restart scenar…
1723799 
…ios (#54881)

Signed-off-by: drake_wang <[email protected]>
(cherry picked from commit e886985)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/lake/compaction/CompactionMgr.java
#	fe/fe-core/src/main/java/com/starrocks/transaction/TransactionStateSnapshot.java
#	fe/fe-core/src/test/java/com/starrocks/lake/compaction/CompactionMgrTest.java
#	fe/fe-core/src/test/java/com/starrocks/lake/compaction/CompactionSchedulerTest.java
@mergify mergify bot mentioned this pull request Jan 22, 2025
Open
18 tasks
wxl24life added a commit to wxl24life/starrocks that referenced this pull request Jan 23, 2025
@wxl24life
[Enhancement] Lake compaction scheduler optimize in fe restart scenar…
708a2fb 
…ios (backport StarRocks#54881)

Signed-off-by: drake_wang <[email protected]>
wxl24life added a commit to wxl24life/starrocks that referenced this pull request Jan 23, 2025
@wxl24life
[Enhancement] Lake compaction scheduler optimize in fe restart scenar…
fe01bb1 
…ios (backport StarRocks#54881)

Signed-off-by: drake_wang <[email protected]>
wxl24life added a commit to wxl24life/starrocks that referenced this pull request Jan 23, 2025
@wxl24life
[Enhancement] Lake compaction scheduler optimize in fe restart scenar…
d96943e 
…ios (backport StarRocks#54881)

Signed-off-by: drake_wang <[email protected]>
smartlxh pushed a commit that referenced this pull request Jan 23, 2025
@wxl24life
[Enhancement] Lake compaction scheduler optimize in fe restart scenar…
5258527 
…ios (backport #54881) (#55368)

Signed-off-by: drake_wang <[email protected]>
wxl24life added a commit to wxl24life/starrocks that referenced this pull request Jan 24, 2025
@wxl24life
[Enhancement] Lake compaction scheduler optimize in fe restart scenar…
058d756 
…ios (backport StarRocks#54881)

Signed-off-by: drake_wang <[email protected]>
wxl24life added a commit to wxl24life/starrocks that referenced this pull request Jan 24, 2025
@wxl24life
[Enhancement] Lake compaction scheduler optimize in fe restart scenar…
b0c2082 
…ios (backport StarRocks#54881)

Signed-off-by: drake_wang <[email protected]>
@wxl24life
Copy link
Contributor Author

backport to branch-3.2 #55388

@wxl24life
Copy link
Contributor Author

backport to branch-3.3 #55389

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starrocks-cr starrocks-cr[bot] starrocks-cr[bot] left review comments

@starrocks-xupeng starrocks-xupeng starrocks-xupeng approved these changes

@caneGuy caneGuy caneGuy approved these changes

@HangyuanLiu HangyuanLiu HangyuanLiu approved these changes

Assignees

@wxl24life wxl24life

Labels
behavior_changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor lake compaction scheduler to keep scheduling unrelated partitions on fe restart
6 participants
@wxl24life @smartlxh @HangyuanLiu @caneGuy @starrocks-xupeng @wanpengfei-git