Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support hive catalog to read json format tables. #54884

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zhuxiangyi
Copy link

@zhuxiangyi zhuxiangyi commented Jan 9, 2025

Why I'm doing:

What I'm doing:

  • Support hivecata to read json format tables.
  • Support hive's own json class org.apache.hive.hcatalog.data.JsonSerDe

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@zhuxiangyi zhuxiangyi requested a review from a team as a code owner January 9, 2025 09:26
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


xiangyi.zhu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@zhuxiangyi zhuxiangyi changed the title [Feature] Support hivecata to read json format tables. [Feature] Support hive catalog to read json format tables. Jan 9, 2025
@wanpengfei-git wanpengfei-git requested a review from a team January 9, 2025 09:26
@zhuxiangyi
Copy link
Author

@kevincai Hi Kevin ,can you review this PR for me

@DorianZheng
Copy link
Contributor

@zhuxiangyi Thanks for filing this issue. Overall LGTM. Please add a SQL test

@kevincai
Copy link
Contributor

@DorianZheng should this PR identified as "Feature" or "Enhancement"? "Feature" PR should be associated with a github feature issue and should NOT be backport to release branch.

Copy link

[FE Incremental Coverage Report]

pass : 7 / 7 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/connector/hive/RemoteFileInputFormat.java 1 1 100.00% []
🔵 com/starrocks/connector/hive/HiveMetastoreApiConverter.java 6 6 100.00% []

Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@zhuxiangyi
Copy link
Author

@kevincai Hi Kevin ,can you review this PR for me
Hi Kevin, thank you very much for your reply, I didn't find any way to do end-to-end SQL test. I added the Format consistency check of Hive Json table in HiveTableTest class.

image

@zhuxiangyi zhuxiangyi force-pushed the hive-supports-json-format branch from 089d8db to 3495689 Compare January 14, 2025 10:58
@zhuxiangyi zhuxiangyi requested a review from dirtysalt January 14, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants