Apply minor optimizations to StringCharStream and JS BitSet #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lppedd
force-pushed
the
refactor/mem-alloc
branch
3 times, most recently
from
1ba60d4 to
ae359e8
Compare
|
@ftomassetti the code looks "worse" than before, but the benefits are pretty amazing for On my laptop - with a 4 megabytes file - I get:
Ken mentioned performance in the email, and I think we have a lot of room for improvement. |
lppedd
commented
Feb 6, 2024
antlr-kotlin-runtime/src/commonMain/kotlin/com/strumenta/antlrkotlin/runtime/ext/String.ext.kt
Outdated
Show resolved
Hide resolved
lppedd
commented
Feb 6, 2024
antlr-kotlin-runtime/src/jsMain/kotlin/com/strumenta/antlrkotlin/runtime/BitSet.kt
Show resolved
Hide resolved
ftomassetti
reviewed
Feb 7, 2024
antlr-kotlin-runtime/src/commonMain/kotlin/com/strumenta/antlrkotlin/runtime/ext/String.ext.kt
Show resolved
Hide resolved
ftomassetti
reviewed
Feb 7, 2024
...in-runtime/src/commonMain/kotlin/org/antlr/v4/kotlinruntime/atn/ATNDeserializationOptions.kt
Show resolved
Hide resolved
ftomassetti
reviewed
Feb 7, 2024
antlr-kotlin-runtime/src/jsMain/kotlin/com/strumenta/antlrkotlin/runtime/BitSet.kt
Show resolved
Hide resolved
|
Added a few minor comments |
lppedd
force-pushed
the
refactor/mem-alloc
branch
from
5e283d3 to
4bb0318
Compare
|
Thank you @lppedd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The optimizations done for
StringCharStreamreduce up to half the time spent indexing code points in very large strings.I've tested it with 4+ megabytes text files.