refactor: Using TypeGPU to alleviate need for manual struct-alignment & bind group index matching. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwoplaza
commented
Dec 30, 2024
Comment on lines
-69
to
-70
| // todo: dive a little deeper into struct memory packing | ||
| // todo: for some reason, this needs to be 4th value, can't be the 1st one? |
There was a problem hiding this comment.
vec3s and vec4s are aligned to multiples of 16 bytes, so:
blurTrailtakes up 4 bytesenableLightingtakes up 4 bytes- (padding of 8 bytes, so that the following vec3f member starts at a multuple of 16)
slimeColortakes up 12 bytes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there! 👋
First of all, I watched your video on YouTube, very impressive showcase of WebGPU. The code is very clear to follow and understand.
I have been working on a TypeScript toolkit to alleviate the most common pain-points of working with WebGPU, with a big focus on type-safety. I wanted to see how easy it would be to incorporate it into an existing WebGPU codebase, and if it would improve the readability or maintainability. Feel free to disregard or close this PR, but if you'd have the time, it would be amazing to get feedback on TypeGPU and its usability from your perspective 💜.
Have a great day!