-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added sampling functionality #85
Open
kb18951452
wants to merge
1
commit into
SumoLogic:master
Choose a base branch
from
kb18951452:sampling
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+46
−1
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
function sampleTraffic(samplingPercent, records) { | ||
if (!samplingPercent) { | ||
return records; | ||
} | ||
var filteredRecords = []; | ||
var toBeSamplesRecords = []; | ||
records.forEach(function (log) { | ||
if ("logLevel" in log.message.message) { | ||
if(Number.isInteger(log.message.message.logLevel)){ | ||
if (log.message.message.logLevel >= 4) { | ||
filteredRecords.push(log); | ||
} else { | ||
toBeSamplesRecords.push(log); | ||
} | ||
} else { | ||
filteredRecords.push(log); | ||
} | ||
} else { | ||
filteredRecords.push(log); | ||
} | ||
}); | ||
if(samplingPercent == 0) { | ||
var increment = 0; | ||
} else { | ||
var increment = 100/samplingPercent; | ||
} | ||
|
||
if(increment > 0) { | ||
for (var i = 0; i < toBeSamplesRecords.length; i += increment) { | ||
filteredRecords.push(toBeSamplesRecords[i]); | ||
} | ||
} | ||
return filteredRecords; | ||
} | ||
|
||
module.exports = { | ||
sampleTraffic: sampleTraffic | ||
}; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's type cast this to integer so that increment is a natural number always.
Also I think we should have a condition samplingPercent > 0 and <= 100 and then we can run a for loop inside it.
Also would be good to break this into two separate functions one for filtering and other for sampling. Filtering one returns filtered + tobesampled records and takes records as input
while sampling one takes tobesampled records and sampling percent as input and returns sampled records
later on we merge the filtered and sampled records