migrate from external mock package to stdlib unittest.mock #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
And yet it somehow broken PyPy 3.9 |
Considering that PyPy 3.9 has segfaulted in the tests, I would very much like to know how my patch resulted in PyPy segfaulting. I do not acknowledge that I broke anything. :) I don't know what happened, but I'm positive that it's not related. Whatever is going on here, it is probably a bug in the PyPy interpreter though. Segfaults usually are. |
|
It might be their bug but it's my problem :) If I merge it I will need to fix it. |
|
Saying that, if changing from PyPy3.9 to 3.10 fixes it then it is fine with me. |
It was moved to the stdlib in python 3.3, and the PyPI version is a backport for python versions less than 3.3.
eli-schwartz
force-pushed
the
stdlib-mock
branch
from
aa49635 to
dac8a03
Compare
eli-schwartz
force-pushed
the
stdlib-mock
branch
from
9347ced to
1ed60fd
Compare
|
That appears to have magically fixed it. |
|
Thanks, merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was moved to the stdlib in python 3.3, and the PyPI version is a backport for python versions less than 3.3.
Note: it was also never a dependendency so there was no guarantee it was installed to be used.