Merge pull request #3640 from SwiftPackageIndex/canonical-debug-panel

Cope with pages that have no canonical in the JS debug panel
SwiftPackageIndex · Jan 28, 2025 · 5ccd4b2 · 5ccd4b2
2 parents 7d645ea + 3dfc88b
commit 5ccd4b2
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/FrontEnd/scripts/debug_panel.js b/FrontEnd/scripts/debug_panel.js
@@ -76,11 +76,11 @@ export class SPIDebugPanel extends HTMLElement {
     }
 
     addCanonicalUrls() {
-        const canonicalUrl = document.querySelector('link[rel="canonical"]').href
+        const canonicalUrl = document.querySelector('link[rel="canonical"]')?.href
         const windowUrl = window.location.href
         const matchingCanonicalUrl = canonicalUrl === windowUrl
 
-        this.newTableRow('Canonical URL', canonicalUrl)
+        this.newTableRow('Canonical URL', canonicalUrl ? canonicalUrl : 'Missing', canonicalUrl ? null : 'red')
         this.newTableRow('Window URL', windowUrl)
         this.newTableRow('Canonical Match', matchingCanonicalUrl, matchingCanonicalUrl ? 'green' : 'red')
     }