Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renewed package collection signing certificate #2701

Merged
merged 3 commits into from
Nov 8, 2023

Conversation

daveverwer
Copy link
Member

No description provided.

@daveverwer
Copy link
Member Author

Do you have an easy way to run this on Linux to update the test_sign_collection.linux.json snapshot, @finestructure?

@finestructure
Copy link
Member

Yes, I can do that tomorrow no worries.

@finestructure
Copy link
Member

Let's see if this passes - the process ended up being a lot more complicated than it used to be. I'll explain once this is working.

@finestructure
Copy link
Member

Ok, so this worked, that's good.

Now to the problem: it appears that with Swift 5.9 we've lost the ability to compile SPI-Server on arm64/Linux. I had to go back to the last Swift 5.8 version 2.91.4 and add the new cert there to get it to generate the new signature.

Alternatively, I could have used our linux builder but I wanted to see if I can get this to run locally.

We'll want to take this to the Swift team, I don't think this compilation failure is project specific. I'll open an issue in our repo to track it and to figure out where to take the details.

It might make sense to set up a CI stage to at least build the project on arm64/Linux to make sure this doesn't break in the future.

@daveverwer daveverwer merged commit 56f7527 into main Nov 8, 2023
3 of 4 checks passed
@daveverwer daveverwer deleted the renew-collection-signing-cert branch November 8, 2023 17:30
@daveverwer
Copy link
Member Author

Thanks for sorting it out! Sorry it was trickier than expected 😬

@daveverwer
Copy link
Member Author

Deploying as 2.92.5 as our collections are currently broken 🫨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants