Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12048] Migrate tests for CreateNotificationActionTest #13209

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

InfinityTwo
Copy link

Part of #12048

Outline of Solution

Added the unit tests for CreateNotificationActionTest for PostgreSQL.

However, two of the tests (testExecute_addNotification_success() and testExecute_invalidParameter_throwsInvalidHttpParameterException()) that fails are disabled, which is inline with the originally disabled tests since it did not work in the first place. The goal here for now was to migrate the code without changing functionality.

Copy link

github-actions bot commented Feb 1, 2025

Hi @InfinityTwo, thank you for your interest in contributing to TEAMMATES!
However, your PR does not appear to follow our contribution guidelines:

  • Description must reference the issue number the PR is fixing, e.g. Fixes #<issue-number> (or Part of #<issue-number> if the PR does not address the issue fully)

Please address the above before we proceed to review your PR.

Copy link
Contributor

@domoberzin domoberzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, just need some auth/access control tests to be added. Good work!

return req;
}

}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add some access control tests as well

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just to add on, i believe the old tests do some authentication (i.e. loginAsAdmin or loginAsInstructor, would be good to carry over that logic where possible

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch, I've added the access control tests 😄

@domoberzin domoberzin requested a review from yuanxi1 February 10, 2025 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants