Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full charge self-consistency with ABINIT #261

Open
wants to merge 6 commits into
base: unstable
Choose a base branch
from

Conversation

GingrasO
Copy link

This PR allows for charge self-consistent calculations with ABINIT. With ABINIT, one perform the Wannier90 calculation and print the DFT occupations in a file "w90_seed.abinit". Those are read by DFTTools. After performing the DMFT loop, the change in the occupations in the band basis are written in the file "w90_seed.delta_N", which is read by ABINIT.

I also corrected a few typos and changed slightly the outputted words. Feel free to remove that.

Copy link
Member

@the-hampel the-hampel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @GingrasO ,

thanks for this addition. This looks very nice. I am happy to merge this as is. However, we should also start then writing some documentation that reflects and add tutorials to use the CSC interface with Abinit? What do you think.
Does this work with the vanilla version of Abinit or some upcoming release?

@GingrasO
Copy link
Author

Hey @the-hampel,

One goal of Azin's internship is to complement the existing benchmark calculations, so we plan on adding to the tutorials as well. At the moment, this is not available in the vanilla version of ABINIT and will be pushed once a few more tests are performed. Do you think we should keep this PR as a separate branch for now? It doesn't conflict with much, so it is possible.

@the-hampel
Copy link
Member

Hi @GingrasO ,
as you like we can keep it here as PR and merge it once ready. Or we can also merge it now and you can make changes later on. For now it will only live in the unstable branch anyway. You choose. Just let me when to merge or review again.

@GingrasO
Copy link
Author

Hi @the-hampel,

Let's wait! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants