Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Starr): Fix HDR10 regex to correctly exclude +/Plus #2240

Merged
merged 1 commit into from
Jan 26, 2025
Merged

fix(Starr): Fix HDR10 regex to correctly exclude +/Plus #2240

merged 1 commit into from
Jan 26, 2025

Conversation

yammes08
Copy link
Contributor

Pull Request

Purpose

To fix an incorrect regex for HDR10.

Approach

Use a negative lookahead condition to properly exclude +/Plus from matching

Open Questions and Pre-Merge TODOs

None

Requirements

@yammes08 yammes08 self-assigned this Jan 26, 2025
@github-actions github-actions bot added Area: Sonarr Sonarr Related Area: Radarr Radarr Related Area: Backend Backend Changes, not related to a specific section Area: Starr Custom Formats Issue is related to custom formats labels Jan 26, 2025
@yammes08 yammes08 marked this pull request as ready for review January 26, 2025 14:25
@yammes08 yammes08 requested a review from nuxencs January 26, 2025 14:25
@yammes08 yammes08 added Type: Bug Found a BUG/Error in the Guide Status: Review Needed Ready for Review labels Jan 26, 2025
@yammes08 yammes08 requested a review from a team January 26, 2025 14:26
@TRaSH-
Copy link
Contributor

TRaSH- commented Jan 26, 2025

@nuxencs could you take a look at the regex?

nuxencs
nuxencs approved these changes Jan 26, 2025
View reviewed changes
Copy link
Contributor

@nuxencs nuxencs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but imo we should go over all these metadata CF and standardise them at some point, to make sure they use the same regex when possible

@bakerboy448 bakerboy448 merged commit 42c2f93 into master Jan 26, 2025
13 checks passed
@bakerboy448 bakerboy448 deleted the fix/hdr10-regex branch January 26, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bakerboy448 bakerboy448 bakerboy448 approved these changes

@nuxencs nuxencs nuxencs approved these changes

Assignees

@yammes08 yammes08

Labels
Area: Backend Backend Changes, not related to a specific section Area: Radarr Radarr Related Area: Sonarr Sonarr Related Area: Starr Custom Formats Issue is related to custom formats Status: Review Needed Ready for Review Type: Bug Found a BUG/Error in the Guide
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yammes08 @TRaSH- @nuxencs @bakerboy448