Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(radarr): Add new Sing-Along Versions custom format #2246

Merged
merged 1 commit into from
Jan 26, 2025
Merged

feat(radarr): Add new Sing-Along Versions custom format #2246

merged 1 commit into from
Jan 26, 2025

Conversation

yammes08
Copy link
Contributor

@yammes08 yammes08 commented Jan 26, 2025 •
edited
Loading

Pull Request

Purpose

Provide a way for Sing-Along versions of movies to be matched and blocked
Resolve #2234

Approach

  • Create new Radarr custom format JSON for Sing-Along Versions, with a default score of -10000
  • Added new custom format with info to all profile unwanted panels, and profile JSONs
  • Added new custom format to Radarr's Collection of Custom Formats page

Open Questions and Pre-Merge TODOs

None

Requirements

@yammes08
Add new Sing-Along Versions custom format for Radarr
4a0d79c 
- Create new custom format JSON for Sing-Along Versions, with a default score of -10000
- Added new custom format with info to all profile unwanted panels, and profile JSONs
- Added new custom format to Radarr's Collection of Custom Formats page
@yammes08 yammes08 self-assigned this Jan 26, 2025
@github-actions GitHub Actions
Copy link
Contributor

@yammes08 your pull request title "feat(Radarr): Add new Sing-Along Versions custom format" does not conform to our naming conventions.

Please update the title to match the pattern: "feat|build|chore|style|fix|update|ci(<area>): <description>

You can check your title at this regex101 link."

@github-actions github-actions bot added Area: Radarr Radarr Related Area: Backend Backend Changes, not related to a specific section Area: Starr Custom Formats Issue is related to custom formats labels Jan 26, 2025
@yammes08 yammes08 added Type: Enhancement Feature Request or Improvement of suboptimal status quo Status: Review Needed Ready for Review Type: Guide Request Requested new guide or enhancements to guide and removed Area: Backend Backend Changes, not related to a specific section labels Jan 26, 2025
@yammes08 yammes08 requested review from TRaSH-, austinwbest and a team January 26, 2025 20:55
@yammes08 yammes08 marked this pull request as ready for review January 26, 2025 20:56
@yammes08 yammes08 changed the title feat(Radarr): Add new Sing-Along Versions custom format feat(radarr): Add new Sing-Along Versions custom format Jan 26, 2025
@yammes08
Copy link
Contributor Author

@austinwbest - FYI, another new custom format. I'm hoping I didn't break the table formatting this time 😄

TRaSH-
TRaSH- approved these changes Jan 26, 2025
View reviewed changes
Copy link
Contributor

@TRaSH- TRaSH- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it locally and loaded all edits in vscode for errors

@yammes08 yammes08 merged commit 5c60275 into master Jan 26, 2025
16 of 17 checks passed
@yammes08 yammes08 deleted the feat/add-new-sing-along-custom-format branch January 26, 2025 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TRaSH- TRaSH- TRaSH- approved these changes

@austinwbest austinwbest Awaiting requested review from austinwbest

Assignees

@yammes08 yammes08

Labels
Area: Radarr Radarr Related Area: Starr Custom Formats Issue is related to custom formats Status: Review Needed Ready for Review Type: Enhancement Feature Request or Improvement of suboptimal status quo Type: Guide Request Requested new guide or enhancements to guide
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(radarr): Add Sing-Along versions custom format
2 participants
@yammes08 @TRaSH-