feat(starr-german): Add Groups to German Tiers #2250
+135
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area: Sonarr
Lokilicious
changed the title
Lokilicious
changed the title
TRaSH-
reviewed
Feb 11, 2025
| "negate": false, | ||
| "required": false, | ||
| "fields": { | ||
| "value": "Jellyfin-Plex$" |
There was a problem hiding this comment.
Just to be sure, doesn't "Jellyfin-Plex$" need to be "^(Jellyfin-Plex)$"?
There was a problem hiding this comment.
As this is a not a release group condition but a release title condition ^(Jellyfin-Plex)$ would not work.
Not 100% sure but a release group condition only matches the string after the last "-" right? So since the Release Group has a "-" in it we need a release title condition to match it properly.
Correct me if im wrong in my assumption.
| "negate": false, | ||
| "required": false, | ||
| "fields": { | ||
| "value": "Jellyfin-Plex$" |
There was a problem hiding this comment.
Just to be sure, doesn't "Jellyfin-Plex$" need to be "^(Jellyfin-Plex)$"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Purpose
Approach
Add groups to CFs
Requirements