Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate Time to Leave to Hindi (Indian Language) #497

Closed
susheelg1197 opened this issue Oct 22, 2020 · 5 comments
Closed

Translate Time to Leave to Hindi (Indian Language) #497

susheelg1197 opened this issue Oct 22, 2020 · 5 comments
Assignees
Labels
enhancement New feature or request localization

Comments

@susheelg1197
Copy link
Contributor

susheelg1197 commented Oct 22, 2020

With reference to issue #475 , I would be translating Time-To-Leave in Hindi (HI) which is an Indian language.
Please assign me this task

@susheelg1197 susheelg1197 added the enhancement New feature or request label Oct 22, 2020
@thamara
Copy link
Collaborator

thamara commented Oct 22, 2020

Sure! Thanks!

@thamara
Copy link
Collaborator

thamara commented Oct 23, 2020

Hi @susheelg1197, in the future, we might add more strings that need a translation too. Would you be interested in be the point of contact for these upcoming contributions? The idea is to make you an ambassador of the Hindi support in the app, and, when we have new translations, we'll mention you to see if you can work on those. This doesn't mean you'll have to translate those of course, only if you are available/interested. Also, you can leave at any time :)

@BhumikaSaini
Copy link
Contributor

BhumikaSaini commented Oct 16, 2021

Hi @thamara,
@susheelg1107 has done a wonderful job adding the translations!
However, some translations need to be corrected. For example, these are the ones that I can see right off the top (will check for more):
Current:

"mon": "मेरे" (translates to "my/mine" in English)
"sat": "बैठ गया" (translates to "sat" as in "sat down" in English, which is semantically correct but wrong in the current context)

These should be:

"mon": "सोम" (translates to "mon" as in "monday", just in Hindi instead)
"sat": "शनि" (translates to "sat" as in "saturday", just in Hindi instead)

Also, I see some instances where we are not truly translating the words but rather, just writing the English word in Hindi letters to have the same, English word sound.
Examples that I can see right off the top (will check for more):

"current-day": "करंट डे पर जाएं" ("करंट डे" is "current day" WRITTEN in Hindi letters, not TRANSLATED)

which could be rephrased to:

"current-day": "वर्तमान दिन पर जाएं"

Would it be better if we use the native language words?

@thamara
Copy link
Collaborator

thamara commented Oct 16, 2021

Hey @BhumikaSaini! Thank you for reporting this.
Yes, it sure would be better to use the native language words.
Would you be interested in reviewing the translation and submitting a PR with the changes you already mentioned as well as other possible improvements you see fit?

@BhumikaSaini
Copy link
Contributor

Sure, will do. Thanks @thamara!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request localization
Projects
None yet
Development

No branches or pull requests

3 participants