-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Gujarati Language to Time-To-leave #679
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @nikkhil31 !
Thanks for the interest in the app and for translating it to a new language!
Please create an issue specifically for Gujarati and edit the comment to not mention "Closes #475 #497" but instead close the new issue you open. We don't want to close #475 because it's an umbrella issue for all translations.
Also, can you use the two letter code gu
instead of guj
, please?
Hello, @tupaschoal I'm creating an issue to add the Gujarati language to TTL. thanks. |
Codecov Report
@@ Coverage Diff @@
## main #679 +/- ##
==========================================
+ Coverage 55.36% 57.15% +1.79%
==========================================
Files 26 26
Lines 2173 2173
Branches 313 313
==========================================
+ Hits 1203 1242 +39
+ Misses 869 835 -34
+ Partials 101 96 -5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks great! Thanks!
As this will need to be merged by hand, I'll do it tomorrow.
\changelog-update |
Thanks again @nikkhil31. Can I add you as a reference for Gujarati? When we have new strings that need translations, you would be mentioned to see if you can work on those. |
My pleasure! @thamara, yes you can add me to reference. 😊 |
Done, thank you so much @nikkhil31 ! |
Related issue
Closes #680
What change is being introduced by this PR?
I have implemented Gujarati Language support to TTL.