Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Gujarati Language to Time-To-leave #679

Merged
merged 3 commits into from
Jun 22, 2021
Merged

Conversation

nikkhil31
Copy link
Contributor

@nikkhil31 nikkhil31 commented Jun 19, 2021

Related issue

Closes #680

What change is being introduced by this PR?

I have implemented Gujarati Language support to TTL.

Copy link
Collaborator

@tupaschoal tupaschoal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @nikkhil31 !

Thanks for the interest in the app and for translating it to a new language!

Please create an issue specifically for Gujarati and edit the comment to not mention "Closes #475 #497" but instead close the new issue you open. We don't want to close #475 because it's an umbrella issue for all translations.

Also, can you use the two letter code gu instead of guj, please?

@nikkhil31
Copy link
Contributor Author

Hello, @tupaschoal
Now, I'm converting this pull request into a draft.
I will add the necessary changes as you mention above.

I'm creating an issue to add the Gujarati language to TTL.
could you pls assign it to me?

thanks.

@nikkhil31 nikkhil31 marked this pull request as draft June 20, 2021 06:21
@nikkhil31 nikkhil31 marked this pull request as ready for review June 21, 2021 05:14
@codecov
Copy link

codecov bot commented Jun 21, 2021

Codecov Report

Merging #679 (58e54d4) into main (337dfb6) will increase coverage by 1.79%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #679      +/-   ##
==========================================
+ Coverage   55.36%   57.15%   +1.79%     
==========================================
  Files          26       26              
  Lines        2173     2173              
  Branches      313      313              
==========================================
+ Hits         1203     1242      +39     
+ Misses        869      835      -34     
+ Partials      101       96       -5     
Impacted Files Coverage Δ
js/classes/BaseCalendar.js 52.49% <0.00%> (+2.68%) ⬆️
js/classes/FlexibleMonthCalendar.js 61.06% <0.00%> (+4.12%) ⬆️
js/classes/FlexibleDayCalendar.js 67.25% <0.00%> (+6.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 337dfb6...58e54d4. Read the comment docs.

Copy link
Collaborator

@thamara thamara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great! Thanks!
As this will need to be merged by hand, I'll do it tomorrow.

@thamara
Copy link
Collaborator

thamara commented Jun 22, 2021

\changelog-update
Message: Translation: Time to Leave is now available in Gujarati (gu)!
User: nikkhil31

@thamara thamara merged commit 7ce6fd3 into TTLApp:main Jun 22, 2021
@thamara
Copy link
Collaborator

thamara commented Jun 22, 2021

Thanks again @nikkhil31. Can I add you as a reference for Gujarati? When we have new strings that need translations, you would be mentioned to see if you can work on those.

@nikkhil31
Copy link
Contributor Author

My pleasure! @thamara, yes you can add me to reference. 😊

@tupaschoal
Copy link
Collaborator

Done, thank you so much @nikkhil31 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translate Time to Leave to Gujarati Language.
3 participants