Fix #1008: Sourced conflicting holidays being imported by default #1011
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #1008
Context / Background
When sourcing holidays, the ones matching existing waivers were tagged as conflicts, but still picked to be added nonetheless
What change is being introduced by this PR?
Now when a conflict is detected, the checkbox will be unchecked by default and also disabled. Turns out that all we needed was to either set the
checked
attribute or not, but we were instead doingchecked=''
orchecked=checked
and it always thought it was checked.How will this be tested?
Test manually, but there are automatic tests for it that I hope still work