Close #1058: Translate TTL to zh-CN (simplified Chinese) #1060
Conversation
There was a problem hiding this comment.
Hi @nh1000, thanks for the PR!
It looks great, I tested and didn't find any problem and everything seems to be translated. I have just made a few line notes. Also, can you revert the changes made to package-lock.json? It shouldn't have been changed.
If you need help, let us know!
|
|
||
| <br/> | ||
|
|
||
| <img src="https://img.shields.io/badge/platforms-Windows%20%7C%20MacOS%20%7C%20Linux-green" alt="Platform"> |
There was a problem hiding this comment.
Technically you can (and should) translate all of the alt tags, since those provide accessibility for users using screen readers.
There was a problem hiding this comment.
I will merge this as is, since the alt tags are a minor detail, but the bulk of the PR is ready and useful. If you ever have time to, please get back to this.
tupaschoal
changed the title
|
@nh1000 ? |
sorry I've been busy lately, will get started implementing the recommended changes now. |
|
Hi @nh1000, sorry to bother, just checking whether you need help! |
sorry for the delay again, I had something come up recently and couldn't work on it, I finish the changes by next week. |
tupaschoal
force-pushed
the
zh-CN-translation
branch
from
cd5b33e to
5cbd115
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1060 +/- ##
==========================================
- Coverage 65.13% 64.09% -1.04%
==========================================
Files 22 22
Lines 3270 3270
Branches 476 470 -6
==========================================
- Hits 2130 2096 -34
- Misses 1140 1174 +34 ☔ View full report in Codecov by Sentry. |
|
\changelog-update |
Related issue
Closes #1058
Context / Background
Adding zh-CN (simplified Chinese) translations
What change is being introduced by this PR?
I followed all the instructions for adding translations noted in #475, meaning that all the changes listed in this issue were made. There were no consequences as a result of the changes made.
How will this be tested?
Hopefully passing the given tests is enough to verify that my changes work. However another Chinese speaker could verify further that my translations are correct.