Translate Time to Leave to Bengali #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tupaschoal
requested changes
Oct 21, 2021
There was a problem hiding this comment.
Thanks @dark-coder155 , this looks great. I have a few comments, mostly regarding formatting
Codecov Report
@@ Coverage Diff @@
## main #797 +/- ##
==========================================
- Coverage 58.42% 57.82% -0.61%
==========================================
Files 26 26
Lines 2220 2212 -8
Branches 315 315
==========================================
- Hits 1297 1279 -18
- Misses 923 933 +10
Continue to review full report at Codecov.
|
Co-authored-by: Tulio Leao <[email protected]>
Co-authored-by: Tulio Leao <[email protected]>
Co-authored-by: Tulio Leao <[email protected]>
Co-authored-by: Tulio Leao <[email protected]>
dark-coder155
commented
Oct 21, 2021
|
@tupaschoal i have fixed pls check |
tupaschoal
requested changes
Oct 23, 2021
Co-authored-by: Tulio Leao <[email protected]>
Co-authored-by: Tulio Leao <[email protected]>
|
yes that was my mistake,sorry for that...check it now @tupaschoal |
tupaschoal
approved these changes
Oct 25, 2021
|
\changelog-update: |
tupaschoal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added bengali version of application and Readme. #795 @tupaschoal