-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close #847: Translate Time To Leave to Hebrew #849
Close #847: Translate Time To Leave to Hebrew #849
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems mostly ready to go, just a few nitpicks.
Codecov Report
@@ Coverage Diff @@
## main #849 +/- ##
=======================================
Coverage 59.42% 59.42%
=======================================
Files 26 26
Lines 2080 2080
Branches 305 305
=======================================
Hits 1236 1236
Misses 844 844 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Removing all other readme links Co-authored-by: Tulio Leao <[email protected]>
\changelog-update |
Thanks @TomerPacific! If in the future we have new or changed strings in the app, can we mention you for help on keeping Hebrew up-to-date? |
@tupaschoal - Of course. You can count on me. |
Cheers! |
Related issue
Closes #847
Context / Background
Following what was detailed in #475, I followed the guidelines and added a translation to Hebrew.
What change is being introduced by this PR?
src/configs/app.config.js
How will this be tested?
I have looked at the markdown in a preview tool to see that it looks appropriately.