Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typings v2 #304

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
- declare annyang namespace in types file
- fix typo in contributing file
hisham committed Aug 24, 2017
commit 57c1fcde699874038c6c804c6503cfc076aaf503
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -22,7 +22,7 @@ A lot of annyang's functionality came from pull requests sent over GitHub. Here
- [x] Run grunt to make sure everything runs smoothly `$ grunt`
- [x] Add tests for your code. [See details below](#automated-testing).
- [x] Code, code, code. Changes should be done in `/src/annyang.js`. They will be transpiled to `/dist/annyang.js` and `/dist/annyang.min.js`.
- [x] If you add new or modify existing functions or update externally facing data structures, update the typescript definition file under `types/index.d.ts` and add test code for dts linting at `types/annyang-tests.ts`
- [x] If you add new or modify existing functions or externally facing data structures, update the typescript definition file under `types/index.d.ts` and add test code for dts linting at `types/annyang-tests.ts`
- [x] Run `$ grunt` after making changes to verify that everything still works and the tests all pass.

:bulb: A great alternative to repeatedly running `$ grunt` is to run `$ grunt watch` once, and leave this process running. It will continuously run all the tests and build the files every time you make a change to one of annyang's files. It will even *beep* if you make an error, and help you debug it. :+1:
Loading