fix(hippy-vue): fix hippy-vue transform multi-animation not working

Tencent · Oct 29, 2020 · 84bd58b · 84bd58b
1 parent 231ec5a
commit 84bd58b
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/packages/hippy-react/src/modules/animation-set.ts b/packages/hippy-react/src/modules/animation-set.ts
@@ -157,7 +157,7 @@ class AnimationSet implements AnimationSet {
    */
   public destroy() {
     this.removeEventListener();
-    this.animationList.forEach(item => item.animationId
+    this.animationList.forEach(item => Number.isInteger(item.animationId)
         && Bridge.callNative('AnimationModule', 'destroyAnimation', item.animationId));
     Bridge.callNative('AnimationModule', 'destroyAnimation', this.animationId);
   }

diff --git a/packages/hippy-vue-native-components/src/animation.js b/packages/hippy-vue-native-components/src/animation.js
@@ -84,7 +84,10 @@ function registerAnimation(Vue) {
     const { transform, ...otherStyles } = style;
     let animationIds = Object.keys(otherStyles).map(key => style[key].animationId);
     if (Array.isArray(transform) && transform.length > 0) {
-      const transformIds = Object.keys(transform[0]).map(key => transform[0][key].animationId);
+      const transformIds = [];
+      transform.forEach(entity => Object.values(entity)
+        .forEach(value => Number.isInteger(value.animationId)
+            && transformIds.push(value.animationId)));
       animationIds = [...animationIds, ...transformIds];
     }
     return animationIds;

diff --git a/packages/hippy-vue/src/runtime/native.js b/packages/hippy-vue/src/runtime/native.js
@@ -31,7 +31,7 @@ const {
 
 const CACHE = {};
 
-const measureInWindowByMethod = function (el, method) {
+const measureInWindowByMethod = function measureInWindowByMethod(el, method) {
   const empty = {
     top: -1,
     left: -1,