tsconfig: update include paths #7423
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjonsson
commented
Dec 27, 2024
tsconfig-node.json
Outdated
| "./lib/Language/**/*", | ||
| "./lib/ReactViews/**/*", | ||
| "./lib/ThirdParty/**/*" | ||
| "./lib/**/*" |
There was a problem hiding this comment.
Why does tsconfig-node.json override the include from tsconfig.json and leave out the tests and buildprocess files?
The explicitly mentioned file is already covered by the general regexp, so remove the file.
Some directories in lib/ are omitted from compilation for some reason. Include lib/**/* instead of the individual directories, just like the base tsconfig does.
pjonsson
force-pushed
the
tsconfig-paths
branch
from
4f0986e to
bf58a2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Remove a file already covered by the general regular expression in tsconfig.json, and
replace the individual subdirectories with a single glob including everything under
lib/in tsconfig-node.json.Test me
Run
yarn build-for-nodeand see that everything under lib is typechecked.Checklist
doc/.