Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement french translation #302

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

YannBirba
Copy link

Hi,

I trying this app as my main meteo app. As i'm french i prefer get the app translated so i did it.
I saw that the developement workflow need many external apis that i don't get/ don't want to setup just to add translations.
So please can you test my changes and leave comments on my pr if i need to update something.

Thank you for all the work you did to create this app !

Copy link

vercel bot commented Jul 16, 2024

@YannBirba is attempting to deploy a commit to the Creative Programming group Team on Vercel.

A member of the Team first needs to authorize it.

@FleetAdmiralJakob
Copy link
Member

Sure, sorry for ignoring you for such a long time, I didn't see the notification for your PR. Let's get this going!

@FleetAdmiralJakob
Copy link
Member

Could you pull in the latest changes from the master branch as there are some critical fixes in them you can also give me access (add me as a contributor) to your fork so I can do it myself.

@YannBirba
Copy link
Author

Could you pull in the latest changes from the master branch as there are some critical fixes in them you can also give me access (add me as a contributor) to your fork so I can do it myself.

Hi ! Thanks for answering! I'll look at that during the week.


// common translations
"common.title": "Weather.io",
"common.location": "Global",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be something reflecting France like in the other languages (Indonesia and German) which are not English too.

@FleetAdmiralJakob
Copy link
Member

Could you pull in the latest changes from the master branch as there are some critical fixes in them you can also give me access (add me as a contributor) to your fork so I can do it myself.

Hi ! Thanks for answering! I'll look at that during the week.

Awesome, thank you. This is one of the discussions we have right now regarding the Chinese translations:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants