This repository has been archived by the owner on Mar 7, 2024. It is now read-only.
Update to Trino-411 #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitrisStaratzis
force-pushed
the
dstara/update_to_trino_411
branch
5 times, most recently
from
9ab4d56 to
b344f12
Compare
DimitrisStaratzis
force-pushed
the
dstara/update_to_trino_411
branch
from
b344f12 to
8df5d13
Compare
| <configuration> | ||
| <parallel>methods</parallel> |
There was a problem hiding this comment.
Parallel testing was creating flakiness
ihnorton
approved these changes
Apr 6, 2023
| * @param attr The attribute | ||
| * @param isString True if the attribute is String | ||
| * @param bound The bound | ||
| * @param op TIleDB operator | ||
| * @return The query Condition | ||
| * @throws TileDBError | ||
| * @throws TileDBError TileDBError |
There was a problem hiding this comment.
Trino 411 introduced more format checks, one of them is that every parameter in the java docs needs to have a description. That's why I added TileDBError
| @@ -542,12 +541,13 @@ else if (attBounds.getSecond() == null) { | |||
|
|
|||
| /** | |||
| * Returns the Query condition for the given bound. | |||
| * | |||
| * @param attr The attribute | |||
| * @param isString True if the attribute is String | |||
| * @param bound The bound | |||
| * @param op TIleDB operator | |||
There was a problem hiding this comment.
Same reason as above, parameters in java docs now need to have one empty line preceding them
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update adds support for Trino-411.
Some dependencies needed to update.
Also, trino removed the
trino.testing....assertEqualsmethod because of this (however the error described in the link did not affect us). I am now using thetestng.AssertEqualsinstead. The modernizer suggested to use thepresto.testing....assertEqualsbut I thought that it is unnecessary to include presto as a dependency and when I tried, several dependency conflicts came up.