Allow magnet links to resolve later when adding URIs #8418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qstokkink
force-pushed
the
fix_magnet_add_slowness
branch
from
493cf4c to
c1e6f7e
Compare
|
validate |
qstokkink
changed the title
egbertbouman
approved these changes
Jan 27, 2025
qstokkink
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8416
This PR:
skipmagnetparameter to thetorrentinfoendpoint, allowing magnet links to resolve later in theSaveAsdialog (or not at all).This should both do all the fancy HTTP forwarding and forward magnet links quickly to the SaveAs dialog. However, the price is another parameter for
getMetainfo().