Update to v41.4.2

.circleci/.stale-bot.js

@@ -12,7 +12,11 @@ module.exports = {
 	GITHUB_TOKEN: process.env.CKE5_GITHUB_TOKEN,
 	REPOSITORY_SLUG: 'ckeditor/ckeditor5',
 	DAYS_BEFORE_STALE: 365,
+	DAYS_BEFORE_STALE_PENDING_ISSUE: 14,
 	DAYS_BEFORE_CLOSE: 30,
+	PENDING_ISSUE_LABELS: [
+		'pending:feedback'
+	],
 	IGNORED_ISSUE_LABELS: [
 		'support:1',
 		'support:2',
@@ -38,7 +42,8 @@ module.exports = {
 		'resolution:expired'
 	],
 	STALE_ISSUE_MESSAGE: 'There has been no activity on this issue for the past year. We\'ve marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you\'re interested in the solution, leave a comment or reaction under this issue.',
+	STALE_PENDING_ISSUE_MESSAGE: 'The issue lacks the feedback we asked for two weeks. Hence, we\'ve marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you\'re interested in the solution, leave a comment or reaction under this issue.',
 	STALE_PR_MESSAGE: 'There has been no activity on this PR for the past year. We\'ve marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you\'re interested in the contribution, leave a comment or reaction under this PR.',
-	CLOSE_ISSUE_MESSAGE: 'We\'ve closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).',
-	CLOSE_PR_MESSAGE: 'We\'ve closed your PR due to inactivity over the last year. While time has passed, the core of your contribution might still be relevant. If you\'re able, consider reopening a similar PR.'
+	CLOSE_ISSUE_MESSAGE: 'We\'ve closed your issue due to inactivity. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).',
+	CLOSE_PR_MESSAGE: 'We\'ve closed your PR due to inactivity. While time has passed, the core of your contribution might still be relevant. If you\'re able, consider reopening a similar PR.'
 };

.circleci/template.yml

@@ -128,6 +128,14 @@ jobs:
           when: always
           name: Execute Stylelint
           command: yarn run stylelint
+      - run:
+          when: always
+          name: Check if all CSS files from the "ckeditor5-theme-lark" are imported in "index.css" file
+          command: yarn run check-theme-lark-imports
+      - run:
+          when: always
+          name: Check if all packages are exported in the "ckeditor5" package
+          command: yarn run check-exports
 
   cke5_coverage:
     machine: true

.eslintrc.js

@@ -32,6 +32,12 @@ module.exports = {
 		]
 	},
 	overrides: [
+		{
+			files: [ './packages/*/src/**/*.ts' ],
+			rules: {
+				'ckeditor5-rules/no-cross-package-svg-imports': 'error'
+			}
+		},
 		{
 			files: [ '**/tests/**/*.@(js|ts)' ],
 			rules: {

.gitignore

@@ -10,6 +10,7 @@
 # Files associated with CKEditor 5 repository.
 **/node_modules
 build/
+dist/
 !packages/ckeditor5-build-*/build
 docs/api/output.json
 yarn.lock

README.md

@@ -67,7 +67,7 @@ In your HTML page, add an element that CKEditor should replace:
 Load the classic editor build (you can choose between the [CDN](https://cdn.ckeditor.com/#ckeditor5), [npm](https://ckeditor.com/docs/ckeditor5/latest/installation/getting-started/predefined-builds.html#npm), and [zip downloads](https://ckeditor.com/docs/ckeditor5/latest/installation/getting-started/predefined-builds.html#zip-download)):
 
 ```html
-<script src="https://cdn.ckeditor.com/ckeditor5/41.0.0/classic/ckeditor.js"></script>
+<script src="https://cdn.ckeditor.com/ckeditor5/41.4.2/classic/ckeditor.js"></script>
 ```
 
 Call the [`ClassicEditor.create()`](https://ckeditor.com/docs/ckeditor5/latest/api/module_editor-classic_classiceditor-ClassicEditor.html#static-function-create) method:

docs/_snippets/build-classic.js

@@ -73,7 +73,7 @@ ClassicEditor.defaultConfig = {
 		toolbar: [
 			'imageStyle:inline',
 			'imageStyle:block',
-			'imageStyle:side',
+			'imageStyle:wrapText',
 			'|',
 			'toggleImageCaption',
 			'imageTextAlternative'

docs/_snippets/features/image-upload.js

@@ -25,7 +25,7 @@ ClassicEditor
 				'|',
 				'imageStyle:inline',
 				'imageStyle:block',
-				'imageStyle:side',
+				'imageStyle:wrapText',
 				'|',
 				'resizeImage:25',
 				'resizeImage:50',
@@ -60,7 +60,7 @@ ClassicEditor
 		ckbox: {
 			tokenUrl: TOKEN_URL,
 			forceDemoLabel: true,
-			allowExternalImagesEditing: [ /^data:/, 'origin' ]
+			allowExternalImagesEditing: [ /^data:/, 'origin', /ckbox/ ]
 		}
 	} )
 	.then( editor => {

docs/_snippets/features/keyboard-support.html

@@ -0,0 +1,6 @@
+<!-- include CKBox from CDN -->
+<script src="https://cdn.ckbox.io/ckbox/latest/ckbox.js"></script>
+
+<div id="keyboard-support">
+	<p>Press <kbd>Alt</kbd>+<kbd>0</kbd> (<kbd>⌥0</kbd> on Mac) while editing to display the list of available keyboard shortcuts.</p>
+</div>