Skip to content

Commit

Permalink
Remove rrule for ReverseDiff
Browse files Browse the repository at this point in the history
`@grad_from_chainrules` can't handle multi-output functions, see JuliaDiff/ReverseDiff.jl#221. In this case it can AD through the primal just fine.
  • Loading branch information
sethaxen committed May 27, 2024
1 parent e47a946 commit a3fe7bb
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion ext/BijectorsReverseDiffExt.jl
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,6 @@ end
@grad_from_chainrules _link_chol_lkj(x::TrackedMatrix)
@grad_from_chainrules _link_chol_lkj_from_upper(x::TrackedMatrix)
@grad_from_chainrules _link_chol_lkj_from_lower(x::TrackedMatrix)
@grad_from_chainrules _inv_link_chol_lkj(x::TrackedVector)

cholesky_lower(X::TrackedMatrix) = track(cholesky_lower, X)
@grad function cholesky_lower(X_tracked::TrackedMatrix)
Expand Down

0 comments on commit a3fe7bb

Please sign in to comment.