Beisher 484 epc review #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…something unexpected
TimLeach635
suggested changes
May 16, 2023
HerPublicWebsite.BusinessLogic/ExternalServices/EpbEpc/EpcEpcDto.cs
Outdated
Show resolved
Hide resolved
HerPublicWebsite.UnitTests/BusinessLogic/ExternalServices/EpbEpc/EpbEpcApiTests.cs
Outdated
Show resolved
Hide resolved
HerPublicWebsite.UnitTests/BusinessLogic/ExternalServices/EpbEpc/EpbEpcDtoTests.cs
Outdated
Show resolved
Hide resolved
HerPublicWebsite.UnitTests/BusinessLogic/QuestionnaireUpdaterTests.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Tim Leach <[email protected]>
Co-authored-by: Tim Leach <[email protected]>
TimLeach635
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the new EPC review page into the flow. Refactors where we call the OSPlaces API and the EPC API.
Also adds a temporary dummy EPC API implementations so you can see the new page.
Also adds a couple of missing fields to the CSV file creation