Memory leak and json output #90
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to make sure that developers can easily operate with antivirus. For that we need to make response easily parsable. With extended JSON output I want to make sure that we can distinguish between files encrypted with password and infected files.
Cleaning up temporary files created by multipart form parsing should resolve growing local FS. `make(chan bool)` is created but never closed, which cause a memory leak.
Open
|
Original mem leak |
|
@James-Royds-HO Hey, could you please have a look? I believe mem leak is annoying for many users. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed the memory leak mentioned in #88 and added verbose json output for making it easier to parse the response.