HYC-1994 - Viewer Notification Workflow #1143
Conversation
| MANAGING = 'managing' | ||
| APPROVING = 'approving' | ||
| DEPOSITING = 'depositing' | ||
| # [hyc-override] Added Viewing role |
There was a problem hiding this comment.
Did this change end up being necessary?
There was a problem hiding this comment.
Technically we could avoid adding the viewer role but I think this change results in our update to roles_for_agent being more consistent.
| end | ||
|
|
||
| # Select users that have the viewing role applied to them more times than the managing role | ||
| only_viewers = user_role_map.select { |user_id, role_counts| role_counts['view'] > role_counts['manage'] } |
There was a problem hiding this comment.
If I'm understanding correctly, if a user is associated with an admin set via multiple assignments (potentially a mix of groups and user roles), this would return true only if the user ends up with more viewer roles than manager? I checked with rebekah, and it sounds like we could actually skip sending viewer notifications if the user has any manager role instead.
Since that's the case, you could potentially have the method return as soon as any manager role is encountered rather than proceeding with both queries, but unless these are slow queries it probably won't have too much of a performance impact.
There was a problem hiding this comment.
Yeah that's correct. Got it, I might have been overthinking a bit — made some changes.
https://unclibrary.atlassian.net/browse/HYC-1994