Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCF-5908 - "UI Support" content model re-org #2117

Open
wants to merge 13 commits into
base: docs-content-model-reorg
Choose a base branch
from

Conversation

siobhan-unity
Copy link
Collaborator

Description

Content model re-org for the Input System's UI Input section.

Testing status & QA

Local build successful.

@unity-cla-assistant
Copy link

unity-cla-assistant commented Jan 28, 2025

CLA assistant check
All committers have signed the CLA.

@ekcoh ekcoh requested a review from duckets January 28, 2025 14:51
Copy link
Collaborator

@jo-unity jo-unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to check the capitals situation for actions / devices / controls etc.

I have overlooked the dev-speak but have made a few suggestions in areas where I found it hard to parse


|**Topic**|**Description**|
|--------|-----------|
|[Supported UI systems](supported-ui-systems.md)|Understand the compatibility between the Input System and Unity's UI systems.|
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor thing but might create inconsistencies - I've been using the template here which bolds each entry in the table https://webcix-hexadocs-content-ops.vercel.app/internal/content-ops/en-us/documentation/content-model/um-landing-page-template

Comment on lines 2 to 4
Unity has [three major UI solutions](https://docs.unity3d.com/Manual/UIToolkits.html). The Input System package's compatibility and workflow with these solutions varies depending on which UI solution you are using, and which version of Unity you are using.

The three main UI systems are **UI Toolkit**, **Unity UI**, and **IMGUI**. Some systems and versions require that you use the Input System’s [UI Input Module component](using-ui-input-module.md) to pass actions from the Input System to the UI.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder whether reorganising this so it reads as a bullet point list with links to each heading in this doc might work better?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did consider this, but I wasn't sure if the links might be confusing. A link with the text "UI Toolkit" could link to the relevant section of this page, OR to the documentation on UI Toolkit.

@@ -0,0 +1,58 @@
# Understand UI system compatibility
Unity has [three major UI solutions](https://docs.unity3d.com/Manual/UIToolkits.html). The Input System package's compatibility and workflow with these solutions varies depending on which UI solution you are using, and which version of Unity you are using.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder whether this intro would work better as a bullet point list with links to each heading in the doc

Comment on lines 7 to 9
Multiple pointer Devices can feed input into a single UI input module. Also, in the case of [Touchscreen](../api/UnityEngine.InputSystem.Touchscreen.html), a single Device can have the ability to have multiple concurrent pointers (each finger contact is one pointer).

Because multiple pointer Devices can feed into the same set of Actions, it is important to set the [action type](./RespondingToActions.md#action-types) to [PassThrough](../api/UnityEngine.InputSystem.InputActionType.html#UnityEngine_InputSystem_InputActionType_PassThrough). This ensures that no filtering is applied to input on these actions and that instead every input is relayed as is.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

device and action need lowercase iirc


The default [project-wide actions asset](./about-project-wide-actions.md) comes with a built-in action map named **UI**, which contains all the actions required for UI interaction. To configure the bindings for these actions, use the [Actions Editor](./actions-editor.md).

To open the Actions Editor:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To open the Actions Editor:
To open the UI action map:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants