refactor: remove duplicate timeouts from WaitFor* methods
#481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kangasta
force-pushed
the
refactor/wait-for-timeouts
branch
2 times, most recently
from
7262bdf to
74b7bfb
Compare
kangasta
force-pushed
the
refactor/wait-for-timeouts
branch
from
74b7bfb to
ab3f348
Compare
peknur
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be invisible for the end-users, thus no CHANGELOG entry. The only case where end-user could have been affected by this is when implementation did set a shorter timeout (e.g. 15 minutes) for a wait loop than the default 20 minutes context deadline configured by Terraform.