Merge pull request #29 from VatsalJagani/ruff-issue-fixes

Python formatting issues fixed.

.github/workflows/py_unit_tests.yml

@@ -37,12 +37,13 @@ jobs:
         - name: Run Python Unit Tests
           run: pytest tests --junitxml=junit/test-results.xml --cov=src --cov-config=tests/.coveragerc --cov-report=xml
 
-        - name: Linting with Ruff
-          run: ruff --output-format=github .
-          continue-on-error: true   # need to remove this later on to catch the errors anf fail the workflow on linting errors
-
         - name: Adding GitHub action step summary
           uses: VatsalJagani/[email protected]
           with:
             pytest_results_file: "junit/test-results.xml"
             pytest_cov_file: "coverage.xml"
+
+        - name: Linting with Ruff
+          run: ruff --output-format=github .
+          # continue-on-error: true   # need to remove this later on to catch the errors anf fail the workflow on linting errors
+

src/app_build_generate.py

@@ -26,7 +26,7 @@ def file_folder_permission_changes():
 
         for file_ext in [".sh", ".exe", ".cmd", ".msi", ".bat"]:
             utils.execute_system_command(
-                "find . -type f -name '*{}' -exec chmod 755 '{}' \;".format(file_ext))
+                f"find . -type f -name '*{file_ext}' -exec chmod 755 '{{}}' \;")
 
         utils.execute_system_command(
             "find . -type d -exec chmod 755 '{}' \;")
@@ -40,7 +40,7 @@ def run_custom_user_defined_commands():
             if cmd:
                 utils.execute_system_command(cmd)
         except Exception as e:
-            utils.warning("Error ")
+            utils.warning(f"Error - {e}")
 
 
 def generate_build(app_build_dir_name, app_build_dir_path):

src/app_inspect.py

@@ -53,8 +53,9 @@ def __init__(self, app_build_path) -> None:
 
         try:
             shutil.rmtree(self.app_inspect_report_dir)
-        except:
-            pass   # nothing to delete if folder not exist
+        except Exception as e:
+            # nothing to delete if folder not exist
+            utils.debug(f"No folder present nothing to be done. {e}")
         os.mkdir(self.app_inspect_report_dir)
 
         self.headers = None

src/app_utilities.py

@@ -1,6 +1,5 @@
 
 import os
-import shutil
 import helpers.github_action_utils as utils
 from utilities.whats_inside_app import WhatsInsideTheAppUtility
 from utilities.logger import LoggerUtility

src/helpers/git_manager.py

@@ -1,7 +1,6 @@
 
 import os
 import re
-import subprocess
 import hashlib
 import helpers.github_action_utils as utils
 

src/helpers/github_action_utils.py

@@ -84,19 +84,19 @@ def group(title):
 
 
 def end_group():
-    print(f"::endgroup::")
+    print("::endgroup::")
 
 
 def add_mask(value):
     print(f"::add-mask::{_escape_data(value)}")
 
 
 def stop_commands():
-    print(f"::stop-commands::pause-commands")
+    print("::stop-commands::pause-commands")
 
 
 def resume_commands():
-    print(f"::pause-commands::")
+    print("::pause-commands::")
 
 
 def save_state(name, value):

src/helpers/global_variables.py

@@ -1,4 +1,5 @@
-import os, re
+import os
+import re
 
 
 class GlobalVariables: