feat(Settings): implement array types #3121
Open
+1,442
−90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also fixes some bugs lol
Repository owner
deleted a comment
Jan 3, 2025
sadan4
reviewed
Jan 3, 2025
src/components/PluginSettings/components/SettingArrayComponent.tsx
Outdated
Show resolved
Hide resolved
…sts' into feat/api/SettingsLists
EepyElvyra
changed the title
EepyElvyra
changed the title
Vendicated
force-pushed
the
feat/api/SettingsLists
branch
from
cda67bf to
bc843c3
Compare
|
i tried to fix conflicts but borked smth :P |
|
Persistent review updated to latest commit 8674764 |
EepyElvyra
force-pushed
the
feat/api/SettingsLists
branch
from
8674764 to
bc843c3
Compare
# Conflicts: # src/components/PluginSettings/PluginModal.tsx # src/plugins/index.ts # src/utils/types.ts
- switch from indices to IDs - make indexes for the channel view unique - Fix guilds shuffling around in the channel view by sorting them alphabetically - Fix possibility to add elements twice from search modal by allowing to hide already added items from the search modal - Remove invalid channels instead of just not rendering them.
EepyElvyra
changed the title
EepyElvyra
changed the title
dolfies
reviewed
Jan 28, 2025
| const invalidChannels: string[] = []; | ||
|
|
||
| for (const item of items) { | ||
| const channel = ChannelStore.getChannel(item); |
There was a problem hiding this comment.
Should this account for channels the user cannot access? Honestly not sure
There was a problem hiding this comment.
honestly idk either
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements: #615 #2210
New option types:
OptionType.ARRAYOptionType.USERSOptionType.CHANNELSOptionType.GUILDSthese replace the previously used strings with separators.
Additionally, context menu entries are generated for all user, channel and guild options.
Since IDs are not user-friendly, this PR additionally implements a Modal replicating Discord's forwarding Modal to search for users/channels/guilds by text.