Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin: FixedForumTags #3124

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

Conversation

sadan4
Copy link
Contributor

@sadan4 sadan4 commented Jan 5, 2025

allows you to search by moderated forum tags

@sadan4 sadan4 changed the base branch from main to dev January 5, 2025 02:16
@sadan4 sadan4 marked this pull request as ready for review January 5, 2025 02:22
@Nuckyz
Copy link
Collaborator

Nuckyz commented Jan 12, 2025

The purpose of this plugin seems very confusing, what even is a moderated tag?

@sadan4
Copy link
Contributor Author

sadan4 commented Jan 12, 2025

The purpose of this plugin seems very confusing, what even is a moderated tag?

a tag that only moderators can add

discord uses the same function to select tags for your own post for the overflow searching menu


## After Fixed Forum Tags

![image](https://github.com/user-attachments/assets/c5fc3349-d998-448f-a6e2-130327128df4)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alt text should either be meaningful if this image is relevant for blind people, or blank to make this image not be included in screen reader

// patches the dropdown menu where overflow forum tags are listed,
// sets the second parameter to true to not ignore moderated forum tags
{
find: "\"-all-tags-dropdown-navigator\"",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
find: "\"-all-tags-dropdown-navigator\"",
find: '"-all-tags-dropdown-navigator"',

{
find: "\"-all-tags-dropdown-navigator\"",
replacement: {
match: /((\i)=\(0,\i\.\i\)\(\i)(\))(?=.*children:\2\.map\()/,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is very ugly try making this better idk what the code looks like but generally you should try getting some less generic string or token in there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants