ShowConnections: Cap max number of connections displayed #3156
+179
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vendicated
reviewed
Jan 20, 2025
| @@ -57,6 +58,11 @@ const settings = definePluginSettings({ | |||
| { label: "Cozy", value: Spacing.COZY }, // US Spelling :/ | |||
| { label: "Roomy", value: Spacing.ROOMY } | |||
| ] | |||
| }, | |||
| maxNumberOfConnections: { | |||
| type: OptionType.NUMBER, | |||
There was a problem hiding this comment.
slider would be better. just do 5-50
There was a problem hiding this comment.
a slider doesn't work due to the fact that the size of the icons is customizable, leading to a multiple of seven -1 not always being the ideal number for an even row
Vendicated
reviewed
Jan 20, 2025
sadan4
commented
Jan 20, 2025
Comment on lines
-104
to
+98
| const profile = UserProfileStore.getUserProfile(id); | ||
| const profile: Partial<UserProfile> = UserProfileStore.getUserProfile(id) ?? {}; |
There was a problem hiding this comment.
not sure what the point of this is in the first place, so not sure if this is the best/correct fix
Vendicated
reviewed
Jan 20, 2025
Vendicated
reviewed
Jan 20, 2025
Vendicated
reviewed
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.