ircColors: fix ColorDot/RoleColorsEverywhere/maybe smth else #3169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't have time to test this right now, but wouldn't this break the member list toggle? Maybe this is desirable. That said, in that case the toggle has to be removed. |
Setting on: Setting off: i haven't touched your patch for member list, so yeah... it works as expected |
|
Also changed TypingTweaks a little |
Vendicated
reviewed
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically instead of modifying just the username, now it's changing color inside of discord's helper func
And this function is used by RoleColorsEverywhere, so it's a win-win situation
https://github.com/Vendicated/Vencord/blob/main/src/plugins/roleColorEverywhere/index.tsx#L28