Updated the way animated emojis are detected #3179
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 29, 2025 15:19
…d emoji as they no longer have the extension .gif
Nuckyz
requested changes
Jan 30, 2025
I checked the contents of url.path and it was /emojis/996768598938882189.webp as I mentioned above discord animated emojis are no longer gifs, in the function you mentioned it checks if it ends with .gif but it checks the path as well so there should be no issue with the method |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discord animated emojis no longer have the extension .gif. They are now .webp with the query parameter animated=true passed to them. I've updated the copyEmojiMarkdown plugin to reflect this as it wasn't copying animated emojis correctly.