Fix issue #556 #582
Open
Fix issue #556 #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/utils.py
Outdated
|
|
||
|
|
||
|
|
||
| def convert_to_pdftext(word_bboxes: list[tuple[float, float, float, float, str]], page_bbox: tuple, page_number: int): |
| get_counter=None): | ||
| """Converts word bboxes (xmin, ymin, xmax, ymax, text) and text into a marker.providers.ProviderOutput object""" | ||
|
|
||
| if get_counter is None: |
There was a problem hiding this comment.
I don't see a case where this would be triggered
There was a problem hiding this comment.
Formatting of the arguments could be better (break into separate lines for readability)
tests/utils.py
Outdated
| from marker.providers.pdf import PdfProvider | ||
| from marker.schema.polygon import PolygonBox | ||
| from marker.schema.text.span import Span as MarkerSpan | ||
| from marker.schema.text.line import Line as MarkerLine |
There was a problem hiding this comment.
Why do these need to be renamed?
There was a problem hiding this comment.
My original intent was to distinguish between the pdftext and marker schemas
tests/utils.py
Outdated
| polygon=PolygonBox.from_bbox([min_x, min_y, max_x, max_y]), | ||
| page_id=page_number, | ||
| block_id=get_counter(), | ||
| # rotation=0 |
There was a problem hiding this comment.
Should remove commented out code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #556 by assigning text to figures in 2nd pass. Also, enhance tests.