SRanipal optimisations

VolcanicArts · Mar 8, 2023 · b45ca69 · b45ca69
1 parent 5777481
commit b45ca69
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 18 deletions.
diff --git a/VRCOSC.Game/Modules/SRanipalAPIInterface.cs b/VRCOSC.Game/Modules/SRanipalAPIInterface.cs
@@ -26,26 +26,16 @@ public void Initialise(bool eye, bool lip)
 
     public void Release()
     {
-        if (eyeAvailable) SRanipalAPI.Release(2);
-        if (lipAvailable) SRanipalAPI.Release(3);
+        SRanipalAPI.Release(2);
+        SRanipalAPI.Release(3);
 
         EyeStatus.SetDefault();
         LipStatus.SetDefault();
     }
 
     public void Update()
     {
-        if (eyeAvailable) updateEye();
-        if (lipAvailable) updateLip();
-    }
-
-    private void updateEye()
-    {
-        SRanipalAPI.GetEyeData(ref EyeData);
-    }
-
-    private void updateLip()
-    {
-        SRanipalAPI.GetLipData(ref LipData);
+        if (eyeAvailable) SRanipalAPI.GetEyeData(ref EyeData);
+        if (lipAvailable) SRanipalAPI.GetLipData(ref LipData);
     }
 }
diff --git a/VRCOSC.Modules/FaceTracking/Interface/SRanipalInterface.cs b/VRCOSC.Modules/FaceTracking/Interface/SRanipalInterface.cs
@@ -27,8 +27,8 @@ public void Initialise(bool eye, bool lip)
     public void Update()
     {
         APIInterface.Update();
-        EyeData.Update(APIInterface.EyeData);
-        LipData.Update(APIInterface.LipData);
+        if (EyeAvailable) EyeData.Update(APIInterface.EyeData);
+        if (LipAvailable) LipData.Update(APIInterface.LipData);
     }
 
     public void Release()

diff --git a/VRCOSC.Modules/FaceTracking/SRanipalModule.cs b/VRCOSC.Modules/FaceTracking/SRanipalModule.cs
@@ -48,6 +48,8 @@ public SRanipalModule()
 
     private void handleStatus(string name, Error status)
     {
+        if (State.Value != ModuleState.Started) return;
+
         switch (status)
         {
             case Error.WORK:
@@ -118,8 +120,8 @@ protected override void OnAvatarChange()
         if (AvatarConfig is null) return;
 
         Log($"Avatar change detected. Parsing avatar {AvatarConfig.Name} with {AvatarConfig.Parameters.Count} parameters");
-        lipParams.ForEach(key => auditParameter(key));
-        eyeParams.ForEach(key => auditParameter(key));
+        if (GetSetting<bool>(SRanipalSetting.EyeEnable)) eyeParams.ForEach(key => auditParameter(key));
+        if (GetSetting<bool>(SRanipalSetting.LipEnable)) lipParams.ForEach(key => auditParameter(key));
 
         var finalCount = parameterData.Select(pair => pair.Value.TotalCount).Sum();
         Log($"Detected {finalCount} usable parameters");