Skip to content

Commit

Permalink
Ensure closing notification is handled on the update thread
Browse files Browse the repository at this point in the history
  • Loading branch information
VolcanicArts committed May 3, 2023
1 parent b8f692b commit d64087d
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion VRCOSC.Desktop/Updater/SquirrelUpdateManager.cs
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ protected override async Task ApplyUpdatesAsync()
}
catch (Exception e)
{
progressNotification.Hide();
progressNotification.Close();

// Update may have failed due to the installed version being too outdated
// Retry without trying for delta
Expand Down
4 changes: 3 additions & 1 deletion VRCOSC.Game/Graphics/Notifications/Notification.cs
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,9 @@ private void load()

protected override bool OnClick(ClickEvent e)
{
Hide();
Close();
return true;
}

public void Close() => Scheduler.Add(Hide);
}

0 comments on commit d64087d

Please sign in to comment.