Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(audio-player): change slider knob design- visible on hover/focus only (VIV-1990) #2090

Merged
merged 8 commits into from
Feb 2, 2025

Conversation

rachelbt
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d61b119) to head (1553e37).
Report is 1260 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##              main     #2090     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files          123       377    +254     
  Lines         1562      9453   +7891     
  Branches       108      1529   +1421     
===========================================
+ Hits          1562      9453   +7891     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rachelbt rachelbt changed the title fix(audio-player): POC for slider inside audio- no knob (VIV-1990) fix(audio-player): change slider knob design- visible on hover/focus onl (VIV-1990) Jan 30, 2025
@rachelbt rachelbt changed the title fix(audio-player): change slider knob design- visible on hover/focus onl (VIV-1990) fix(audio-player): change slider knob design- visible on hover/focus only (VIV-1990) Feb 2, 2025
@rachelbt rachelbt merged commit b1b19c4 into main Feb 2, 2025
16 checks passed
@rachelbt rachelbt deleted the VIV-1990-audio-slider branch February 2, 2025 10:45
@github-actions github-actions bot mentioned this pull request Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants