-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add toString, equals and hashCode to public domain objects #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #508 +/- ##
============================================
+ Coverage 94.26% 95.19% +0.93%
+ Complexity 2892 2874 -18
============================================
Files 426 426
Lines 6919 6824 -95
Branches 449 392 -57
============================================
- Hits 6522 6496 -26
+ Misses 204 200 -4
+ Partials 193 128 -65
|
a79373c
to
18cdbbc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Along with addressing #134, this PR aims to add convenience when debugging API responses and using the deserialised objects in collections, by implementing the
equals
andhashCode
methods. ThetoString
is implemented based on the class name and serialised JSON value. A reflective approach is taken to all these methods, using a common base object for JSON payloads in the form ofcom.vonage.client.JsonableBaseObject
, which is implemented throughout the entire classs hierarchy / object graph for all JSON responses, and even some requests.