Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Relax downloadRecording validation #557

Merged
merged 1 commit into from
Dec 19, 2024
Merged

fix: Relax downloadRecording validation #557

merged 1 commit into from
Dec 19, 2024

Conversation

SMadani
Copy link
Contributor

@SMadani SMadani commented Dec 19, 2024

Removes unnecessary validation of the URL domain in the downloadRecording method of Voice API implementation.

@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.00%. Comparing base (fe06b81) to head (a689f6d).
Report is 73 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #557      +/-   ##
============================================
+ Coverage     95.60%   96.00%   +0.39%     
- Complexity     3427     3753     +326     
============================================
  Files           513      564      +51     
  Lines          8141     8702     +561     
  Branches        451      497      +46     
============================================
+ Hits           7783     8354     +571     
+ Misses          198      175      -23     
- Partials        160      173      +13     
Files with missing lines Coverage Δ
src/main/java/com/vonage/client/HttpWrapper.java 100.00% <ø> (ø)
...main/java/com/vonage/client/voice/VoiceClient.java 97.29% <100.00%> (+0.07%) ⬆️

... and 34 files with indirect coverage changes

@SMadani SMadani merged commit b6b29ff into main Dec 19, 2024
17 checks passed
@SMadani SMadani deleted the recording branch December 19, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants